Skip to content

[skip-changelog] Migrate tests from test_cache.py to cache_test.go #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure enhancement

What is the new behavior?

This PR is a followup to PR #1806
The integration test TestCacheClean, that was previously present in test_cache.py, has been rewritten in cache_test.go without changing its original purpose.

Does this PR introduce a breaking change, and is titled accordingly?

No


See how to contribute

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Aug 17, 2022
@MatteoPologruto MatteoPologruto self-assigned this Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #1839 (0b7eaf1) into master (c756472) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
+ Coverage   36.26%   36.34%   +0.07%     
==========================================
  Files         232      232              
  Lines       19496    19496              
==========================================
+ Hits         7071     7086      +15     
+ Misses      11594    11583      -11     
+ Partials      831      827       -4     
Flag Coverage Δ
unit 36.34% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arduino/cores/packagemanager/package_manager.go 63.02% <0.00%> (+0.84%) ⬆️
arduino/monitor/monitor.go 47.36% <0.00%> (+6.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MatteoPologruto MatteoPologruto marked this pull request as ready for review August 17, 2022 09:35
@cmaglie cmaglie merged commit f43c9ec into master Aug 22, 2022
@cmaglie cmaglie deleted the test-cache branch August 22, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants